-
Notifications
You must be signed in to change notification settings - Fork 255
[QE] fix windows pr check failure #4706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request fixes a failure in the Windows QE check by modifying the windows-qe-tpl.yml workflow file. The changes include adding a CPU specification and excluding an additional region from spot instances. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lilyLuLiu - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be helpful to add a comment explaining why these specific regions are excluded from spot instances.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
windows pr check failure is also caused by redhat-developer/mapt#456 |
Can you add some explanations in the commit log or the PR description explaining why we need to add more CPUs and ignore another region? |
The windows PR failed because the reserved machine cup is not enough to start a VM. The mapt default number 8 is not working as expect (issue redhat-developer/mapt#456). Hold this pr and wait this mapt issue get fixed. |
Description
Fixes: #N
Relates to: #N, PR #N, ...
Type of change
test, version modification, documentation, etc.)
Proposed changes
Testing
Contribution Checklist
Summary by Sourcery
Update Windows QE workflow configuration to improve VM creation parameters
Enhancements:
CI: