Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests: nvm run --silent and nvm exec --silent #846

Open
ljharb opened this issue Sep 23, 2015 · 2 comments
Open

Add tests: nvm run --silent and nvm exec --silent #846

ljharb opened this issue Sep 23, 2015 · 2 comments
Labels
pull request wanted This is a great way to contribute! Help us out :-D testing Stuff related to testing nvm itself.

Comments

@ljharb
Copy link
Member

ljharb commented Sep 23, 2015

I added support for --silent to nvm run and nvm exec in eb81fba for #842.

However, I was lazy, and didn't write any tests.

This issue is a reminder for me, or a request to anyone else, to write these tests. They should ensure that the output is correct without --silent, with --silent, and also that --silent is only swallowed and respected when it's in the third argument position (immediately after run or exec).

@ljharb ljharb added testing Stuff related to testing nvm itself. pull request wanted This is a great way to contribute! Help us out :-D labels Sep 23, 2015
@dr15x86
Copy link

dr15x86 commented Oct 13, 2015

👍
when i call nvm run --silent /tmp/123.js with not empty .nvmrc
nvm always prompt to stdout Found '/home/..../.nvmrc' with version <stable>

@ljharb
Copy link
Member Author

ljharb commented Oct 13, 2015

ah, thank you! I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request wanted This is a great way to contribute! Help us out :-D testing Stuff related to testing nvm itself.
Projects
None yet
Development

No branches or pull requests

2 participants