-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] nvm exec
/nvm run
: add --silent
tests
#1259
Conversation
test/slow/nvm run/Running "nvm run --silent" should work
Outdated
Show resolved
Hide resolved
Thanks!! |
d11bc3f
to
120f7b4
Compare
Hmm do you know why it's still failing? The output and expected output should be matching now 🤔 |
test/slow/nvm run/Running "nvm run --silent" should work
Outdated
Show resolved
Hide resolved
test/slow/nvm run/Running "nvm run --silent" should work
Outdated
Show resolved
Hide resolved
3538de3
to
eaa8148
Compare
@jumbosushi are you still interested in completing this PR? |
eaa8148
to
c4fd0d1
Compare
nvm exec
/nvm run
: add --silent
tests
c4fd0d1
to
639aaf9
Compare
@jumbosushi i've rebased this, but the tests are failing. |
c6cfc3a
to
c20db2a
Compare
13ae700
to
2cba2f7
Compare
Co-authored-by: Atsushi Yamamoto <yamaatsushi927@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
93771a7
to
9f520c9
Compare
Turns out that the expected output in the 2nd case was incorrect, and the 1st case wasn't testing the full output. That's now been fixed. |
New Stuff - `install.sh`: add `$ZDOTDIR` to zsh search (#3458) Fixes - `reinstall-packages`: do not reinstall corepack (#3544) - avoid bash-specific syntax (#3499) - `install-latest-npm`: npm v11 is out - `nvm_install_latest_npm`: avoid unbound variable (#3447) - give a more helpful message when `lts` alias is mistakenly used (#3441) - `nvm ls`, `nvm alias`, `nvm install`: error when an LTS name is invalid - `nvm_normalize_lts`: error when an LTS name is not lowercase (#3417) Documentation - [readme] update link - [readme] fix `--no-use` example (#3479) - [readme] update copyright notice (#3507) - [readme] note zsh-nvm's AUTO_USE option (#2670) - [readme] add note about reloading zshrc after editing (#3052) - [readme] Update shell profile file install notes (#2241) - [readme] add docker tips (#2318) - [readme] remove `avn` from readme (#3469) - [readme] fnm -> nvm.fish (#2541) Refactors - prefer `case` over if/else chains - combine `sed -e` invocations/arguments Tests - `nvm exec`/`nvm run`: add `--silent` tests (#1259) - [actions] release test needs git tags - migrate `installation_iojs` test suite to GitHub Actions (#3476) - Migrate slow test suite from Travis CI (#3470) - temporarily skip this failing travis test to unblock progress - [actions] TOC: use latest LTS node - `install.sh`: clean up `nvm_detect_profile` tests - `nvm_detect_profile`: refactor (#3467) - run urchin tests on pull requests (#3466) - update mocks - ensure that unit tests use only mocked LTS names - [actions] use `node/install` instead of `node/run` Meta - disable blank issues - update issue template - add DCO (#3456) - Rename .github/ISSUE_TEMPLATE.md to .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md (#3454)
As requested by @ljharb on issue #846, this pr adds tests for --silent flag for "run" and "exec" commands
The tests for "exec" seems to exist already but in a different naming convention, so I renamed to match other tests