Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[readme] fnm -> nvm.fish #2541

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[readme] fnm -> nvm.fish #2541

merged 1 commit into from
Feb 3, 2025

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 18, 2021

fnm has been renamed to nvm.fish and the repo has been transferred to https://github.com/jorgebucaran.

@ljharb
Copy link
Member

ljharb commented Jul 18, 2021

That’s unfortunate; i thought @jorgebucaran and i went through this with the name not being “nvm” years ago.

@jorgebucaran
Copy link

Yes, I renamed it to fnm, but when that other fnm came into the picture a few years ago, I went back to nvm, adding .fish to the name, so its actual name is nvm.fish. Not nvm. The README also states in its first sentence that we're not affiliated to this project.

Not that POSIX-compatible script.

@ljharb
Copy link
Member

ljharb commented Jul 18, 2021

So rather than ask the new fnm to rename to avoid the conflict, you decided to create a new conflict?

@jorgebucaran
Copy link

In my view, there is no conflict. nvm is an sh script. nvm.fish is a Fish one.

There's also a thread on Twitter with more background if anyone is interested. Also Schniz/fnm#3.

@kidonng
Copy link
Contributor Author

kidonng commented Jul 18, 2021

Yep, I stand with @jorgebucaran here. It may be the case years ago, but I don't think nowadays anyone consider nvm to refer to something else than this project.

@ljharb ljharb marked this pull request as draft December 23, 2022 20:21
@ljharb ljharb force-pushed the master branch 2 times, most recently from c6cfc3a to c20db2a Compare June 10, 2024 18:13
@ljharb
Copy link
Member

ljharb commented Feb 3, 2025

This confusion empirically continues; people think nvm-windows is nvm constantly, and the only reason I don't see it for nvm.fish is likely because fish itself is so rarely used. However, obviously the readme should point to the correct project, so I'll rebase and pull this in.

@ljharb ljharb marked this pull request as ready for review February 3, 2025 19:03
@ljharb ljharb changed the title Update fnm link in README [readme] fnm -> nvm.fish Feb 3, 2025
@ljharb ljharb merged commit 572c757 into nvm-sh:master Feb 3, 2025
169 of 171 checks passed
ljharb added a commit that referenced this pull request Mar 11, 2025
@ljharb
v0.40.2
ffec9fe 
New Stuff
 - `install.sh`: add `$ZDOTDIR` to zsh search (#3458)

Fixes
 - `reinstall-packages`: do not reinstall corepack (#3544)
 - avoid bash-specific syntax (#3499)
 - `install-latest-npm`: npm v11 is out
 - `nvm_install_latest_npm`: avoid unbound variable (#3447)
 - give a more helpful message when `lts` alias is mistakenly used (#3441)
 - `nvm ls`, `nvm alias`, `nvm install`: error when an LTS name is invalid
 - `nvm_normalize_lts`: error when an LTS name is not lowercase (#3417)

Documentation
 - [readme] update link
 - [readme] fix `--no-use` example (#3479)
 - [readme] update copyright notice (#3507)
 - [readme] note zsh-nvm's AUTO_USE option (#2670)
 - [readme] add note about reloading zshrc after editing (#3052)
 - [readme] Update shell profile file install notes (#2241)
 - [readme] add docker tips (#2318)
 - [readme] remove `avn` from readme (#3469)
 - [readme] fnm -> nvm.fish (#2541)

Refactors
 - prefer `case` over if/else chains
 - combine `sed -e` invocations/arguments

Tests
 - `nvm exec`/`nvm run`: add `--silent` tests (#1259)
 - [actions] release test needs git tags
 - migrate `installation_iojs` test suite to GitHub Actions (#3476)
 - Migrate slow test suite from Travis CI (#3470)
 - temporarily skip this failing travis test to unblock progress
 - [actions] TOC: use latest LTS node
 - `install.sh`: clean up `nvm_detect_profile` tests
 - `nvm_detect_profile`: refactor (#3467)
 - run urchin tests on pull requests (#3466)
 - update mocks
 - ensure that unit tests use only mocked LTS names
 - [actions] use `node/install` instead of `node/run`

Meta
 - disable blank issues
 - update issue template
 - add DCO (#3456)
 - Rename .github/ISSUE_TEMPLATE.md to .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md (#3454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jorgebucaran jorgebucaran jorgebucaran approved these changes

Assignees
No one assigned
Labels
informational shell: fish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kidonng @ljharb @jorgebucaran