-
Notifications
You must be signed in to change notification settings - Fork 20
replication: add replication state to GetVolumeReplicationInfo response #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More discussion is required before deciding on this particular approach.
f7da44e
to
34637e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
34637e3
to
d0251af
Compare
d0251af
to
9c92b24
Compare
…oResponse add status and status_message to GetVolumeReplicationInfoResponse that describes the current replication state to the end user. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
9c92b24
to
d4b08f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this will not cause any problem when both server and clients are on different versions
@Rakshith-R You have requested changed on this PR, PTAL |
add
replication_state
to GetVolumeReplicationInfo response.Fixes: #78