Skip to content

feat: bump deps #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2024
Merged

feat: bump deps #150

merged 5 commits into from
Dec 16, 2024

Conversation

Mister-Hope
Copy link
Contributor

No description provided.

@Mister-Hope
Copy link
Contributor Author

The minimal node requirement is 18.19.0, and it seems netlify is failing because it's using a wrong version.

@CosmoMyzrailGorynych
Copy link
Collaborator

Will sort out the Netlify problem and the PR soon 👍 It's wild to see you here, I assume your VuePress theme finally releases? Thank you for the update in any case 👏

@CosmoMyzrailGorynych
Copy link
Collaborator

The minimal node requirement is 18.19.0, and it seems netlify is failing because it's using a wrong version.

🤔 Netlify is using Node.js v20.18.1

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Dec 16, 2024

image

Weird, the log clearly show that an export of built-in module is not available.

image

https://nodejs.org/api/fs.html#fspromisesconstants

That means, the runner must be in a node version which is 18.0 - 18.3 or <= 16.17 @CosmoMyzrailGorynych

@Mister-Hope
Copy link
Contributor Author

I believe you can merge this first, then go to the env panel to force using node 22 with NODE_ENV=22 and redeploy it.

Netlify may have some sperate settings with the preview (PR perview) feature.

@CosmoMyzrailGorynych
Copy link
Collaborator

And you're right about an environment variable (: Why is one even able to set the same thing in several places...

изображение

@CosmoMyzrailGorynych CosmoMyzrailGorynych merged commit 31caa86 into ct-js:master Dec 16, 2024
5 checks passed
@CosmoMyzrailGorynych
Copy link
Collaborator

@Mister-Hope if you need more links, I made a new smaller website running on your theme just this week: https://buntralino.github.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants