Skip to content

Deprecate src-related functions and methods #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krlmlr opened this issue May 2, 2021 · 1 comment · Fixed by #531
Closed

Deprecate src-related functions and methods #527

krlmlr opened this issue May 2, 2021 · 1 comment · Fixed by #531
Milestone
0.2.0

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented May 2, 2021

because they have alternatives and the concept is being phased out of dplyr.
@krlmlr krlmlr added this to the 0.2.0 milestone May 2, 2021
@krlmlr krlmlr mentioned this issue May 3, 2021
Merged
krlmlr added a commit that referenced this issue May 3, 2021
@krlmlr
Merge pull request #531 from cynkra/f-527-deprecate-src
fd1488d 
- Deprecate `dm_get_src()` `tbl.dm()`, `src_tbls.dm()`, `copy_to.dm()`. These functions have better alternatives and use the notion of a "data source" which is being phased out of dplyr (#527).
krlmlr added a commit that referenced this issue May 4, 2021
@krlmlr
Merge tag 'v0.2.0' into docs
00b989d 
dm 0.2.0

- Deprecate `dm_get_src()` `tbl.dm()`, `src_tbls.dm()`, `copy_to.dm()`. These functions have better alternatives and use the notion of a "data source" which is being phased out of dplyr (#527).
- `*_pk()` and `*_fk()` functions gain an ellipsis argument that comes before `check`, `force` and `rm_referencing_fks` arguments (#520).

- `dm_add_pk()` and `dm_add_fk()` support compound keys via the `c()` notation, e.g. `dm_add_pk(dm, table, c(col1, col2))`. `dm_nycflights13()` returns a data model with compound keys by default. Use `compound = FALSE` to return the data model from dm v0.1.13 or earlier (#3).
- `dm_get_all_fks()` includes `parent_pk_cols` column that describes the primary key columns of the parent table (#335).
- `dm_from_src()` supports the `schema` argument also for MariaDB and MySQL databases (#516).
- dm objects now inherit from `"dm_v1"` in addition to `"dm"`, to allow backward-compatible changes of the internal format (#521).
- Use hack to create compound primary keys on the database (#522).
- `dm_examine_constraints()` and other check functions count the number of rows that violate constraints for primary and foreign keys (#335).
- `copy_dm_to(set_key_constraints = FALSE)` downgrades unique indexes to regular indexes (#335).
- `rows_truncate()` implemented for data frames (#335).
- `dm_enum_fk_candidates()` enumerates column in the order they apper in the table (#335).
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Deprecate dplyr src methods cynkra/dm
1 participant
@krlmlr