-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Weave Cypress Cloud, UI Coverage, and Cypress Accessibility more closely into the narrative of the docs #5947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some typo changes
and suggestions where I wasn't quite sure what is best / right
Linting also needs to be run for minor formatting discrepancies.
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@MikeMcC399 Thanks for the quick review. This is a very rough draft at this point. There are a LOT more changes to come. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review every line of this PR, but I clicked around the preview a lot to see if anything looked off to me and everything seems to be working great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is too large to review using regular tools. I did however notice one issue building the web:
[WARNING] Docusaurus found 1 unused Markdown directives in file "docs/cloud/features/smart-orchestration/run-cancellation.mdx"
- :::ingo (71:1)
Your content might render in an unexpected way. Visit https://github.com/facebook/docusaurus/pull/9394 to find out why and how to fix it.
@MikeMcC399 Yah, I suspect we’ll find some things and need to do followup PRs as we do. |
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Update the IA of the docs to incorporate Cypress Cloud, UI Coverage, and Cypress Accessibility more fully into the docs in preparation for Cypress Conf 2024.