-
Notifications
You must be signed in to change notification settings - Fork 37
feat: add start option to post build #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bahmutov
merged 8 commits into
cypress-io:add-post-build-start
from
alexjfno1:post-build-start-command
Mar 29, 2021
Merged
feat: add start option to post build #151
bahmutov
merged 8 commits into
cypress-io:add-post-build-start
from
alexjfno1:post-build-start-command
Mar 29, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
537e58d
to
09f17a3
Compare
09f17a3
to
cf1a871
Compare
cf1a871
to
f8c17ad
Compare
@bahmutov do I need to configure something to get the build on CircleCI to work correctly? |
It is pretty annoying, since it requires to use Netlify during tests, thus it needs private token, ughh. Let me merge your PR into my branch then all the tests will run and we will see. |
bahmutov
added a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
Added
This PR adds the ability to specify a custom
start
command,wait-on
&wait-on-timeout
in thepostBuild
stage of the build. It mimics the behaviour of the options in thepreBuild
stage.Example:
It also contains refactoring of the
index.js
file to break it into smaller files as I felt it was getting too large. Jest has also been added for unit testing of these files.Tasks
start
option ininputs.postBuild
which will run the command instead of serving the public folder. If nostart
command is specified the original behavior still exists.npm run test:unit
.onPostBuild
.index.js
into smaller files.