Treat null as undefined. #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem in principle, but I believe this might break a lot of applications that rely (knowingly or not) on null being treated as 0. And I don't see a way to evaluate the risk (eg by searching for examples in blocks or observable). |
|
I am confident we can proceed with this as a patch release. I think it is more likely that null data is inaccurately being misrepresented as zero than people are relying on null implicitly representing zero. |
skovhus
added a commit
to electricitymaps/electricitymaps-contrib
that referenced
this pull request
Aug 3, 2021
null in quantitative scales is now considered an “unknown” value. d3/d3-scale#241
skovhus
added a commit
to electricitymaps/electricitymaps-contrib
that referenced
this pull request
Aug 3, 2021
null in quantitative scales is now considered an “unknown” value. d3/d3-scale#241
skovhus
added a commit
to electricitymaps/electricitymaps-contrib
that referenced
this pull request
Aug 6, 2021
* Allow delay in history graph * Upgrade d3-scale null in quantitative scales is now considered an “unknown” value. d3/d3-scale#241 * Fix history mix graph * Update check as production is always present * Make area graph handle null values * Make time slider hourly * Only run validation when production values are there * Add preview flags to API calls * Upgrade build image for d3-scale * Fix timeslider timescale Co-authored-by: skovhus <kenneth.skovhus@gmail.com> Co-authored-by: Kenneth Skovhus <skovhus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m surprised we didn’t find this sooner, but I think it’s appropriate for quantitative scales to treat null as undefined, rather than implicitly coercing null to zero. This makes d3-scale more consistent with d3-array.