-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing laz extension #288
Conversation
I've just made a simple timing comparison and it looks like there is a drastic performance difference between
I think that difference stems from the fact that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @SBCV ! Could you please add a test case for thins kind odd files to:
def test_from_file(data_path, extension, color, mesh): |
Hola @SBCV !
Nice!. I did not know about the existence of pylas (I think it did not exist back when the .las reader was added). It looks like a good and more active alternative, would be nice for a P.R. |
In order to add the requested test to test_from_file.py , I opened diamond.las with Cloudcompare and stored the imported point cloud as
Do you know, if it is it possible to create laz files with 32 bit floats? Or should we change the assertions? |
I'm guessing that CloudCompare is exporting with float64: I don't know if you can change the exported precission. Rather than changing assertions, I think that the best option would be to cast the point coordinates to float32 (maybe using a default argument in order to let someone get float64 if needed): https://github.com/daavoo/pyntcloud/blob/master/pyntcloud/io/las.py#L28 |
Added default arguments for float and color. The test case for pytest runs now successfully (including color information). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SBCV !
Thank you for merging. Regarding |
The
laspy
library allows to read not onlylas
but alsolaz
files (assuming thatlaszip
is installed)Btw: Are you aware of the pylas / lazperf libraries?
They also allow to read
las
/laz
files and can be installed usingpip
(which is more convenient than the installation oflaspy
andlaszip
)