-
Notifications
You must be signed in to change notification settings - Fork 229
fix: broken relative imports for proto output types generation #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: broken relative imports for proto output types generation #555
Conversation
8bef2b8
to
2dd20e3
Compare
Can you check please? @danielgtaylor, @Gobot1234 |
Please can you add a test for this case? |
Done, can you check? |
@Gobot1234 Can you process with review? |
Please can you run the code through black |
@Gobot1234 fixed pre-commit hooks issues |
@Gobot1234 is any chance this fix will be released in next weeks/month? |
@Gobot1234 , @danielgtaylor Any news guys? |
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Not sure why linux CI is failing |
Hi @danielgtaylor , i am also facing the broken relative imports issue. when can we merge this PR ? |
It will be merged when the CI is fixed |
Results seem to have aged out, but I think the lack of this PR is why betterproto doesn't work with the Protobufs I'm trying to use now. |
Summary
Checklist