Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15842 control: Reject re-join with different control addr #14470

Merged
merged 1 commit into from
Jun 5, 2024
Merged

DAOS-15842 control: Reject re-join with different control addr #14470

merged 1 commit into from
Jun 5, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented May 29, 2024 •
edited
Loading

Previously the re-join was succeeding but not updating the address, which led to surprising behavior. With this change, the re-join fails and notifies the admin.

Features: control

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-15842 control: Reject re-join with different control addr
afd2886 
Previously the re-join was succeeding but not updating the address,
which led to surprising behavior. With this change, the re-join
fails and notifies the admin.

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque self-assigned this May 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

Ticket title is 'Need documentation about changing IP addresses/URIs'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-15842

@kjacque kjacque marked this pull request as ready for review May 30, 2024 02:02
@kjacque kjacque requested review from a team as code owners May 30, 2024 02:02
@kjacque kjacque requested review from mjmac and tanabarr May 30, 2024 02:02
@kjacque kjacque requested a review from knard38 May 31, 2024 21:01
@kjacque kjacque requested a review from a team June 3, 2024 15:25
@mjmac mjmac merged commit f2f32dc into master Jun 5, 2024
57 checks passed
@mjmac mjmac deleted the kjacque/change-control-ip-error branch June 5, 2024 12:41
kjacque added a commit that referenced this pull request Jun 6, 2024
@kjacque
DAOS-15842 control: Reject re-join with different control addr (#14470)
b00ce62 
Previously the re-join was succeeding but not updating the address,
which led to surprising behavior. With this change, the re-join
fails and notifies the admin.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
mjmac pushed a commit that referenced this pull request Jun 11, 2024
@kjacque
DAOS-15842 control: Reject re-join with different control addr (#14470)…
684d40e 
… (#14526)

Previously the re-join was succeeding but not updating the address,
which led to surprising behavior. With this change, the re-join
fails and notifies the admin.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanabarr tanabarr tanabarr approved these changes

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@kjacque kjacque

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjacque @tanabarr @knard38 @mjmac