Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15919 chk: rollback generation if failed to start checker #14579

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Nasf-Fan
Copy link
Contributor

The chk_bookmark::cb_gen for leader may be refreshed during start checker even if the start process failed for some reason finally. Under such case, we need to recover the chk_bookmark::cb_gen back to its original value (before the failed 'chk start'); otherwise, if some former in-running instance failed current 'chk start', it will affect subsequent 'chk stop' command to stop such instance.

Test-tag: cat_recov

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

The chk_bookmark::cb_gen for leader may be refreshed during start
checker even if the start process failed for some reason finally.
Under such case, we need to recover the chk_bookmark::cb_gen back
to its original value (before the failed 'chk start'); otherwise,
if some former in-running instance failed current 'chk start', it
will affect subsequent 'chk stop' command to stop such instance.

Test-tag: cat_recov

Signed-off-by: Fan Yong <fan.yong@intel.com>
Copy link

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - CR10 DER_INVAL(-1003) != DER_SUCCESS(0)'
Status is 'In Progress'
Labels: 'ci_impact,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-15919

@Nasf-Fan Nasf-Fan marked this pull request as ready for review June 18, 2024 03:36
@Nasf-Fan Nasf-Fan requested review from liw and kjacque June 18, 2024 03:36
@Nasf-Fan Nasf-Fan requested review from liw, gnailzenh and liuxuezhao and removed request for liw June 21, 2024 01:00
@Nasf-Fan
Copy link
Contributor Author

Related patch has been landed to master, wait for backport to release/2.6

@Nasf-Fan Nasf-Fan requested a review from a team June 26, 2024 07:24
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 26, 2024
@daltonbohning daltonbohning merged commit cd1835d into release/2.6 Jun 26, 2024
49 of 50 checks passed
@daltonbohning daltonbohning deleted the Nasf-Fan/DAOS-15919_1_b26 branch June 26, 2024 14:59
@mjmac mjmac mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

5 participants