DAOS-16076 test: Automate dmg scale test to be run on Aurora

[shimizukko]

Steps:

1. Format storage
2. System query
3. Create a 100% pool that spans all engines
4. Pool query
5. Pool destroy
6. Create 49 pools spanning all the engines with each pool using a 1/50th of the capacity
7. Pool list
8. Get around 80 pool metrics
9. Destroy all 49 pools
10. System stop
11. System start

Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

• Two review approvals and any prior change requests have been resolved.
• Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• Commit messages follows the guidelines outlined here.
• Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• You are the appropriate gatekeeper to be landing the patch.
• The PR has 2 reviews by people familiar with the code, including appropriate owners.
• Githooks were used. If not, request that user install them and check copyright dates.
• Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• All builds have passed. Check non-required builds for any new compiler warnings.
• Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• If applicable, the PR has addressed any potential version compatibility issues.
• Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• Extra checks if forced landing is requested
  • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • No new NLT or valgrind warnings. Check the classic view.
  • Quick-build or Quick-functional is not used.
• Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions]

Ticket title is 'Automate dmg scale test to be run on Aurora'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16076

[rpadma2]

Any reason why we want to keep this here? I feel we have to use the metrics list available under TelemetryUtils.py.

[shimizukko]

I think it's better to keep them here because these are scattered across different variables in TelemetryUtils.py. Also, they can be moved around or removed by someone else in TelemetryUtils.py.

[daltonbohning]

FWIW @phender And I have gone back and forth on this too. I tend to agree with @shimizukko here: keeping them here makes it much less likely that someone accidentally breaks them in the utils

[daltonbohning]

Better to not put formatting for log_step because it already formats the messages

Suggested change

	self.log_step("## System query")
	self.log_step("System query")

[shimizukko]

This is printed as:
==> Step 4: ## System query [elapsed since last step: 0.00s]
If we don't use ##, We could search with ==>, but I'm using ## in other places such as total pool create duration. In my experience, it's easier to search with the same search string across the entire job.log than switching the strings to search different values.

[daltonbohning]

Thoughts @phender ? Similar rationale has come up before

[shimizukko]

I think the cleaner way is to measure the duration for each step, but now we use the harness for some operations such as self.server_managers[0].system_stop(), so measuring the command duration isn't straightforward. Also, this test is manually executed only at RC (4 times in each RC), so I'm not sure if I want to put more effort into it.

[saurabhtandan]

LGTM

[daltonbohning]

@shimizukko I didn't think about it until after merging, but couldn't this be made to work in CI so we know if the test is accidentally broken?