Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… #14662

Merged
merged 3 commits into from
Aug 12, 2024
Merged

DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… #14662

merged 3 commits into from
Aug 12, 2024

Conversation

soumagne
Copy link
Collaborator

…ecv buffers

Default to 16 multi-recv buffers instead of 4

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

Ticket title is 'Aurora ECB testing: 256ECB:105 servers - ior with MPIIO/DFS EC_16P2GX hung'
Status is 'In Progress'
Labels: 'daos_ecb_issue,daos_ecb_scale,request_for_2.6.1,scrubbed_2.8,triaged'
https://daosio.atlassian.net/browse/DAOS-15914

@soumagne soumagne force-pushed the soumagne/mrecv_buf branch 4 times, most recently from f509062 to 27146dc Compare July 1, 2024 19:42
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@daos-stack daos-stack deleted a comment from daosbuild1 Jul 1, 2024
@soumagne soumagne force-pushed the soumagne/mrecv_buf branch 2 times, most recently from e34e7ff to 778d3bd Compare August 6, 2024 22:32
@daos-stack daos-stack deleted a comment from daosbuild1 Aug 6, 2024
@soumagne
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
cb7330b 
…ecv buffers

Default to 16 multi-recv buffers instead of 4

Switch to using HG_Init_opt2() to select init info version

Add also D_MRECV_BUF_COPY to control copy threshold of multi-recv buffers
(default is disabled)

Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne force-pushed the soumagne/mrecv_buf branch from 778d3bd to cb7330b Compare August 6, 2024 22:38
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14662/9/testReport/

@soumagne
DAOS-15914 cart: update README.env
9484a55 
Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne marked this pull request as ready for review August 7, 2024 21:24
@soumagne soumagne requested review from a team as code owners August 7, 2024 21:24
@soumagne soumagne mentioned this pull request Aug 7, 2024
Merged
18 tasks
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14662/10/execution/node/1441/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14662/10/execution/node/1551/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14662/11/execution/node/520/log

@soumagne
DAOS-15914 cart: retrigger CI
12b09c8 
Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne requested review from daltonbohning, mchaarawi, a team and jolivier23 August 12, 2024 14:51
@frostedcmos frostedcmos merged commit 101f18c into master Aug 12, 2024
56 checks passed
@frostedcmos frostedcmos deleted the soumagne/mrecv_buf branch August 12, 2024 17:19
soumagne added a commit that referenced this pull request Aug 12, 2024
@soumagne
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… (
0b53e80 
#14662)

Default to 16 multi-recv buffers instead of 4

Switch to using HG_Init_opt2() to select init info version

Add also D_MRECV_BUF_COPY to control copy threshold of multi-recv buffers
(default is disabled)

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
soumagne added a commit that referenced this pull request Aug 12, 2024
@soumagne
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… (
eec4a77 
#14662)

Default to 16 multi-recv buffers instead of 4

Switch to using HG_Init_opt2() to select init info version

Add also D_MRECV_BUF_COPY to control copy threshold of multi-recv buffers
(default is disabled)

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 12, 2024
@soumagne @daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… (
460a801 
#14662)

Default to 16 multi-recv buffers instead of 4

Switch to using HG_Init_opt2() to select init info version

Add also D_MRECV_BUF_COPY to control copy threshold of multi-recv buffers
(default is disabled)

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 13, 2024
@soumagne
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… (
485fced 
#14662) (#14683)

Default to 16 multi-recv buffers instead of 4

Switch to using HG_Init_opt2() to select init info version

Add also D_MRECV_BUF_COPY to control copy threshold of multi-recv buffers
(default is disabled)

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
jolivier23 added a commit that referenced this pull request Aug 19, 2024
@jolivier23
Revert "DAOS-15914 cart: add D_MRECV_BUF env var to control number of…
4d0d372 
… multi-r… (#14662) (#14683)"

This reverts commit 485fced.
@jolivier23 jolivier23 mentioned this pull request Aug 19, 2024
Merged
jolivier23 added a commit that referenced this pull request Oct 29, 2024
@jolivier23
Reapply "DAOS-15914 cart: add D_MRECV_BUF env var to control number o…
03639cb 
…f multi-r… (#14662) (#14683)"

This reverts commit 4d0d372.
@jolivier23 jolivier23 mentioned this pull request Oct 29, 2024
Merged
jolivier23 added a commit that referenced this pull request Oct 30, 2024
@jolivier23
Reapply "DAOS-15914 cart: add D_MRECV_BUF env var to control number o…
ff63c34 
…f multi-r… (#14662) (#14683)"

This reverts commit 4d0d372.
jolivier23 added a commit that referenced this pull request Nov 1, 2024
@jolivier23
Reapply "DAOS-15914 cart: add D_MRECV_BUF env var to control number o…
f6308ff 
…f multi-r… (#14662) (#14683)"

This reverts commit 4d0d372.
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmoore-or jgmoore-or jgmoore-or approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumagne @daosbuild1 @jgmoore-or @frostedcmos