DAOS-16013 tools: Query all pool targets by default #14783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `daos pool query-targets` with just a rank argument should query all targets on that rank. Required-githooks: true Change-Id: Ib5fff358769679f8c282372fdfa8eaba2b5471cd Signed-off-by: Michael MacDonald <mjmac@google.com>
|
Ticket title is 'daos pool query-targets outputs nothing' |
kjacque
previously approved these changes
Jul 18, 2024
|
For symmetry should the dmg pool query-targets command support the same? |
Hmm. Missed that! Yes, it should. Thanks for pointing it out, will push an update. |
Required-githooks: true Change-Id: Ia89439318f767b386f29fdc3be7b32b6d229ee07
Required-githooks: true Change-Id: I8e6f475c41e055c5aa687df0a398082daa06f887 Signed-off-by: Michael MacDonald <mjmac@google.com>
tanabarr
requested changes
Jul 24, 2024
Required-githooks: true Change-Id: I413d017d400540ebbcd3322608bffcadf87e2c46 Signed-off-by: Michael MacDonald <mjmac@google.com>
It's not easy to thoroughly test this, but I've added what I can without heroics. |
kjacque
approved these changes
Jul 24, 2024
knard38
approved these changes
Jul 25, 2024
mjmac
added a commit
that referenced
this pull request
Jul 31, 2024
Running `(daos|dmg) pool query-targets` with just a rank argument should query all targets on that rank. Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac
added a commit
that referenced
this pull request
Aug 5, 2024
Running `(daos|dmg) pool query-targets` with just a rank argument should query all targets on that rank. Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac
added a commit
that referenced
this pull request
Aug 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
daos pool query-targetswith just a rankargument should query all targets on that rank.
Required-githooks: true
Change-Id: Ib5fff358769679f8c282372fdfa8eaba2b5471cd
Signed-off-by: Michael MacDonald mjmac@google.com