Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16286 client: intercept fdatasync() #14835

Merged
merged 1 commit into from
Jul 31, 2024
Merged

DAOS-16286 client: intercept fdatasync() #14835

merged 1 commit into from
Jul 31, 2024

Conversation

wiliamhuang
Copy link
Contributor

@wiliamhuang wiliamhuang commented Jul 29, 2024

To intercept function fdatasync() in libpil4dfs.

Features: pil4dfs

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Features: pil4dfs

Required-githooks: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang wiliamhuang marked this pull request as ready for review July 29, 2024 16:30
@wiliamhuang wiliamhuang requested review from a team as code owners July 29, 2024 16:30
Copy link

github-actions bot commented Jul 29, 2024

Ticket title is 'Application crash with libpil4dfs.so interception library -- fdatasync: Bad file descriptor'
Status is 'In Review'
Labels: 'HPE'
https://daosio.atlassian.net/browse/DAOS-16286

@wiliamhuang
Copy link
Contributor Author

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14835/1/testReport/

@wiliamhuang
Copy link
Contributor Author

The only failed test is a known issue reported in ticket https://daosio.atlassian.net/browse/DAOS-16035.
@wangshilong @knard-intel Could you please review? Thank you very much!

@wiliamhuang wiliamhuang requested a review from mchaarawi July 31, 2024 14:06
@wiliamhuang wiliamhuang requested a review from a team July 31, 2024 14:13
@mchaarawi mchaarawi merged commit a0af03d into master Jul 31, 2024
52 of 54 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-16286 branch July 31, 2024 14:15
@mchaarawi
Copy link
Contributor

looks straightforward / simple enough to request for 2.6.1

@wiliamhuang
Copy link
Contributor Author

looks straightforward / simple enough to request for 2.6.1

ok. I will create a backport for 2.6.1. Thank you!

wiliamhuang added a commit that referenced this pull request Aug 1, 2024
Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang
Copy link
Contributor Author

#14859
PR for release/2.6.1 was created.

daltonbohning pushed a commit that referenced this pull request Aug 2, 2024
Signed-off-by: Lei Huang <lei.huang@intel.com>
@mjmac mjmac mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants