Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16035 rebuild: create VOS cont when no record need to be rebuilt… #14841

Merged
merged 2 commits into from
Aug 12, 2024
Merged

DAOS-16035 rebuild: create VOS cont when no record need to be rebuilt… #14841

merged 2 commits into from
Aug 12, 2024

Conversation

liuxuezhao
Copy link
Contributor

… (#14819)

For EC object rebuild, some ext not exist on some shards, for this case create VOS container when no record need to be rebuilt. To avoid following IO cannot find container and fail at obj_ioc_init() -> cont_child_lookup().
Another case is in cont_snap_update_one() create the vos cont if non-exist.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners July 30, 2024 14:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_rebuild_ec - REBUILD45 20 bytes of 0x7ffe86d6c390 and 0x7ffe86d6c3b0 differ'
Status is 'Awaiting backport'
Labels: '2.6.0rc3,ci_master_daily,pr_test,scrubbed_2.8,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16035

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14841/1/testReport/

@liuxuezhao
Copy link
Contributor Author

only one test failure due to DAOS-16215 (dfuse daos build)

@liuxuezhao liuxuezhao requested review from liw and NiuYawei August 1, 2024 14:13
liw
liw previously approved these changes Aug 1, 2024
View reviewed changes
@liuxuezhao liuxuezhao requested review from liw, wangshilong and a team August 1, 2024 14:16
@liuxuezhao liuxuezhao added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 1, 2024
jolivier23
jolivier23 previously approved these changes Aug 5, 2024
View reviewed changes
@liuxuezhao liuxuezhao requested a review from a team August 7, 2024 00:53
@liuxuezhao liuxuezhao added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 7, 2024
@liuxuezhao liuxuezhao removed the request for review from a team August 7, 2024 03:12
@liuxuezhao liuxuezhao dismissed stale reviews from jolivier23 and liw via 48f64a4 August 7, 2024 03:18
@liuxuezhao liuxuezhao force-pushed the lxz/rb_cont_exist_26 branch from 7d1d954 to 48f64a4 Compare August 7, 2024 03:18
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 7, 2024
@liuxuezhao
Copy link
Contributor Author

pushed commit 2 to fix a regression of commit 1.

@liuxuezhao liuxuezhao requested a review from jolivier23 August 7, 2024 03:18
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14841/2/execution/node/1593/log

@liuxuezhao
DAOS-16035 rebuild: create VOS cont when no record need to be rebuilt (…
d5e1a27 
…#14819)

For EC object rebuild, some ext not exist on some shards, for this case
create VOS container when no record need to be rebuilt. To avoid
following IO cannot find container and fail at obj_ioc_init() ->
cont_child_lookup().
Another case is in cont_snap_update_one() create the vos cont if
non-exist.

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao
DAOS-16308 container: create ULT for ds_cont_tgt_snapshots_update
062ba30 
Possibly yield in vos_cont_create() -> bio_wal_commit() -> wait_tx_committed(),
so tasklet cannot work.

Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao liuxuezhao force-pushed the lxz/rb_cont_exist_26 branch from 48f64a4 to 062ba30 Compare August 8, 2024 09:16
@NiuYawei NiuYawei merged commit 19e880c into release/2.6 Aug 12, 2024
51 of 52 checks passed
@NiuYawei NiuYawei deleted the lxz/rb_cont_exist_26 branch August 12, 2024 01:15
@cdavis28 cdavis28 mentioned this pull request Aug 12, 2024
Merged
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liw liw liw approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@wangshilong wangshilong Awaiting requested review from wangshilong

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuxuezhao @daosbuild1 @liw @NiuYawei @jolivier23