Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16368 doc: Fix typo in dfuse documentation #14951

Merged
merged 1 commit into from
Aug 16, 2024
Merged

DAOS-16368 doc: Fix typo in dfuse documentation #14951

merged 1 commit into from
Aug 16, 2024

Conversation

jolivier23
Copy link
Contributor

--disable-wb-caching should be --disable-wb-cache

Doc-only: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jolivier23
DAOS-16368 doc: Fix typo in dfuse documentation
434b47d 
--disable-wb-caching should be --disable-wb-cache

Doc-only: true

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 requested a review from a team as a code owner August 16, 2024 20:26
@jolivier23 jolivier23 requested review from mchaarawi and Michael-Hennecke and removed request for a team August 16, 2024 20:26
@github-actions GitHub Actions
Copy link

Ticket title is 'documentation should use --disable-wb-cache, not --disable-wb-caching'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16368

@jolivier23 jolivier23 requested a review from wiliamhuang August 16, 2024 20:53
@jolivier23 jolivier23 merged commit bed9bec into master Aug 16, 2024
38 checks passed
@jolivier23 jolivier23 deleted the jvolivie/update_doc branch August 16, 2024 22:53
@jolivier23
Copy link
Contributor Author

@Michael-Hennecke does this need to be backported to fix the doc?

jolivier23 added a commit that referenced this pull request Aug 20, 2024
@jolivier23
DAOS-16368 doc: Fix typo in dfuse documentation (#14951)
dedf707 
--disable-wb-caching should be --disable-wb-cache

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23 added a commit that referenced this pull request Aug 20, 2024
@jolivier23
DAOS-16368 doc: Fix typo in dfuse documentation (#14951)
48e3279 
--disable-wb-caching should be --disable-wb-cache

Doc-only: true

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
mchaarawi pushed a commit that referenced this pull request Aug 20, 2024
@jolivier23
DAOS-16368 doc: Fix typo in dfuse documentation (#14951) (#14968)
edfbb0d 
--disable-wb-caching should be --disable-wb-cache

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@juszhan1 juszhan1 mentioned this pull request Aug 26, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchaarawi mchaarawi mchaarawi approved these changes

@wiliamhuang wiliamhuang wiliamhuang approved these changes

@Michael-Hennecke Michael-Hennecke Awaiting requested review from Michael-Hennecke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jolivier23 @mchaarawi @wiliamhuang