Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14348 client: GC for pil4dfs dentry cache #14995

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

knard38
Copy link
Contributor

@knard38 knard38 commented Aug 23, 2024

Miscellaneous

Hotfix of miscellaneous issues:

  • invalid type of atomic_flag
  • invalid usage of DL_WARN macro

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Hotfix of miscellaneous issues:
- invalid type of atomic_flag
- invalid usage of DL_WARN macro

Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
@knard38 knard38 self-assigned this Aug 23, 2024
Copy link

Ticket title is 'pil4dfs dentry caching'
Status is 'Resolved'
Labels: 'intercept_lib'
https://daosio.atlassian.net/browse/DAOS-14348

@mchaarawi
Copy link
Contributor

let's also create a 2.6 backport please since i will approve that to be merged there

@knard38
Copy link
Contributor Author

knard38 commented Aug 23, 2024

let's also create a 2.6 backport please since i will approve that to be merged there

Done with PR #14996

@knard38 knard38 marked this pull request as ready for review August 28, 2024 07:10
@knard38 knard38 requested review from a team as code owners August 28, 2024 07:10
@knard38 knard38 requested a review from a team August 29, 2024 06:34
@knard38
Copy link
Contributor Author

knard38 commented Aug 29, 2024

@daos-stack/daos-gatekeeper , please could you lend this patch with the following messages:

  • Title: DAOS-14348 client: GC for pil4dfs dentry cache
  • Body:
Hotfix of miscellaneous issues:
- invalid type of atomic_flag
- invalid usage of DL_WARN macro

@mchaarawi mchaarawi merged commit 3d129b2 into master Aug 29, 2024
55 checks passed
@mchaarawi mchaarawi deleted the ckochhof/hotfix/master/daos-14348 branch August 29, 2024 14:32
jolivier23 pushed a commit that referenced this pull request Aug 29, 2024
Hotfix of miscellaneous issues:
- invalid type of atomic_flag
- invalid usage of DL_WARN macro

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants