DAOS-16585 tests: Improve NLT checking of ioil metrics. #15179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is 'NLT test failures under Ubuntu 22.04' |
|
Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15179/1/execution/node/816/log |
Use the ioil statistics to verify read/write counts rather than just checking for function name. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
ashleypittman
force-pushed
the
amd/nlt-il-stats
branch
from
4b62c7f to
c6ae1b4
Compare
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
|
I just ran this on Ubuntu 22.04 and got errors: |
|
Weird errors under Rocky 8: |
|
That Ubuntu stack trace is exactly what I'd expect, the code is still failing on Ubuntu but at least it's not clear why that is. The second stack includes daos_reinit which I know is an area of change in master to work across fork so I'm not worried about that - but it is an indication that we shoud test pydaos on that distro again. |
jolivier23
approved these changes
Sep 30, 2024
I'm confused what you want to do about the Rocky errors (which I still see, including if I cherry-pick commits to the google/2.6 branch)? They're going to crop up if we try to deploy the script to our local presubmits...can we either fix the errors or disable the relevant check and file a bug to re-enable? Or explain more if there's something I'm missing? FYI: I'm running on Rocky 8.10. |
|
Ah ha...I just discovered I was running with python 3.6 and it seems happier if I upgrade to 3.9. If I was running a too old, unsupported python version, my bad! |
techbasset
approved these changes
Oct 3, 2024
Please do keep looking at this as we still expect python 3.6 to work, at the very least file a ticket or speak to Johann about it. |
|
techbasset
pushed a commit
that referenced
this pull request
Oct 15, 2024
Use the ioil statistics to verify read/write counts rather than just checking for function name. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ioil statistics to verify read/write counts rather
than just checking for function name.
Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com