Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16768 pool: larger ABT ULT stack sizes #15832

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Feb 3, 2025

With this change, three ULTs in pool and container code launched via ds_pool_thread_collective() are changed to specify a larger ("deep") stack size of 64KiB rather than a default 16KiB stack size. i.e., the flags parameter specified as DSS_ULT_DEEP_STACK. The three ULT function entrypoints are:
cont_open_one, cont_snap_update_one,and update_vos_prop_on_targets.

Before this change, intermittently in CI testing, shortly after daos_engine startup, a dmg pool list (pool query on the back end) would occasionally result in a segmentation fault in an engine, in these three particular areas of the code. Specifically, the faults occurred within the ABT thread create, inside ABTI_mem_pool_alloc().

This change is based on a guess that the stack size parameter may have some effect.

Features: pool container test_engine_restart

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Sorry, something went wrong.

With this change, three ULTs in pool and container code launched via
ds_pool_thread_collective() are changed to specify a larger ("deep")
stack size of 64KiB rather than a default 16KiB stack size. i.e., the
flags parameter specified as DSS_ULT_DEEP_STACK. The three ULT
function entrypoints are:
cont_open_one, cont_snap_update_one,and update_vos_prop_on_targets.

Before this change, intermittently in CI testing, shortly after
daos_engine startup, a dmg pool list (pool query on the back end)
would occasionally result in a segmentation fault in an engine, in
these three particular areas of the code. Specifically, the faults
occurred within the ABT thread create, inside ABTI_mem_pool_alloc().

This change is based on a guess that the stack size parameter may have
some effect.

Features: pool container test_engine_restart

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
@kccain kccain added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Ticket title is 'server/daos_server_restart.py:DaosServerTest.test_engine_restart - test timeout - pool list takes 300 seconds'
Status is 'In Review'
Labels: '2.6.2tb2,2.6.3rc1,2.7.101tb,ci_2.6_daily,ci_master_daily,daily_test'
https://daosio.atlassian.net/browse/DAOS-16768

@kccain kccain requested review from jolivier23 and tanabarr February 3, 2025 16:02
@phender phender marked this pull request as ready for review February 4, 2025 13:19
@phender phender requested review from a team as code owners February 4, 2025 13:19
@phender phender requested a review from a team February 4, 2025 13:19
@phender phender merged commit 08cc2cd into release/2.6 Feb 4, 2025
57 checks passed
@phender phender deleted the kccain/daos_16768_deep_stack_size_rel2p6 branch February 4, 2025 13:20
kccain added a commit that referenced this pull request Feb 27, 2025
Revert "DAOS-16768 pool: larger ABT ULT stack sizes (#15832)"

This reverts commit 08cc2cd.

Features: pool container

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
@mjmac mjmac mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants