Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16990 cart: workaround to CXI init errors with retrying HG init … #15837

Merged
merged 1 commit into from
Feb 4, 2025
Merged

DAOS-16990 cart: workaround to CXI init errors with retrying HG init … #15837

merged 1 commit into from
Feb 4, 2025

Conversation

mchaarawi
Copy link
Contributor

…(#15833)

This is a workaround for DAOS-16990 and DAOS-17011.

When using the CXI provider, retry HG_Init_opt2() on error cases since it seems CXI has intermittent issues on initialization. A new environment variable is added (CRT_CXI_INIT_RETRY) to control the retry count (default is 3) and to be able to test future SS fixes without retry.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@mchaarawi
DAOS-16990 cart: workaround to CXI init errors with retrying HG init (#…
2ecc82a 
…15833)

This is a workaround for DAOS-16990 and DAOS-17011.

When using the CXI provider, retry HG_Init_opt2() on error cases since
it seems CXI has intermittent issues on initialization. A new
environment variable is added (CRT_CXI_INIT_RETRY) to control the retry
count (default is 3) and to be able to test future SS fixes without
retry.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
@mchaarawi mchaarawi marked this pull request as ready for review February 3, 2025 23:03
@mchaarawi mchaarawi requested review from a team as code owners February 3, 2025 23:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Ticket title is 'Mercury init fails with fi_cq_open failed, rc: -17 (File exists)'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16990

@mchaarawi mchaarawi added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 4, 2025
@mchaarawi mchaarawi requested a review from a team February 4, 2025 01:08
@mchaarawi mchaarawi merged commit 45f09a3 into release/2.6 Feb 4, 2025
52 of 53 checks passed
@mchaarawi mchaarawi deleted the mschaara/cxi_init_retry-2.6 branch February 4, 2025 01:57
This was referenced Feb 14, 2025
Closed
Merged
@mjmac mjmac mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostedcmos frostedcmos frostedcmos approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchaarawi @frostedcmos