Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17107 rsvc: Add some logging #15910

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DAOS-17107 rsvc: Add some logging #15910

wants to merge 1 commit into from

Conversation

liw
Copy link
Contributor

@liw liw commented Feb 14, 2025

Add info logging for rsvc events such as "successfully distributed a new
version of the map" and "retrying the distribution of the map due to
this error".

Log skipped ranks in pool_svc_exclude_ranks. Add missing parameter
documentation for pool_svc_update_map_internal.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Feb 14, 2025

Ticket title is 'Aurora test cluster lost engine after upgrading to 2.6.3-3 from 2.6.3-2 (Cluster restored)'
Status is 'Blocked'
Labels: 'ALCF,alcf_track'
https://daosio.atlassian.net/browse/DAOS-17107

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15910/1/execution/node/1420/log

Add info logging for rsvc events such as "successfully distributed a new
version of the map" and "retrying the distribution of the map due to
this error".

Log skipped ranks in pool_svc_exclude_ranks. Add missing parameter
documentation for pool_svc_update_map_internal.

Signed-off-by: Li Wei <liwei@hpe.com>
@liw liw force-pushed the liw/log-map-dist branch from c475e4a to 95bc607 Compare March 19, 2025 04:45
@liw liw changed the title DAOS-17107 rsvc: Add important info logging DAOS-17107 rsvc: Add some logging Mar 19, 2025
@liw liw marked this pull request as ready for review March 19, 2025 04:47
@liw liw requested review from a team as code owners March 19, 2025 04:47
@liw liw requested review from liuxuezhao and kccain March 19, 2025 04:48
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15910/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15910/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15910/2/display/redirect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants