DAOS-16922 dfuse: Avoid assertion on shutdown (#15972) #16011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is ' Assertion 'atomic_load_relaxed(&ie->ie_open_count) == 0' ' |
When there are open file handles and dfuse is shutdown using umount -f, it would assert due to resources being used. Rather than asserting, just print a warning that we are shutting down ungracefully. Change-Id: I7998eb4e418e71814cd0407ca60fe387ed3bb285 Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23
force-pushed
the
jvolivie/dfuse_assert
branch
from
d018ae2 to
e15294b
Compare
mjmac
approved these changes
Mar 4, 2025
pavelgritsai
reviewed
Mar 4, 2025
| @@ -1,5 +1,6 @@ | |||
| /** | |||
| * (C) Copyright 2016-2024 Intel Corporation. | |||
| * (C) Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
Is this what we do? Curious to learn more about this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are open file handles and dfuse is shutdown using umount -f, it would assert due to resources being used. Rather than asserting, just print a warning that we are shutting down ungracefully.
Steps for the author:
After all prior steps are complete: