b/402103828: Increase xstream stack size #16085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
mjmac
force-pushed
the
dev/mjmac/b402103828
branch
from
e9100f7 to
89fdc71
Compare
The stack size set for the server xstreams and the NVMe polling ULT is 64K. This size seems to result in occasional segfaults on engine startup, likely due to being near a limit. Doubling the stack size for these ULTs should avoid the problem. Change-Id: Id339cc48985825ccce291ad288e1490920facf5c Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac
force-pushed
the
dev/mjmac/b402103828
branch
from
89fdc71 to
2d28e88
Compare
mjmac
changed the title
wangdi1
approved these changes
Mar 13, 2025
jolivier23
approved these changes
Mar 13, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack size set for the server xstreams and
the NVMe polling ULT is 64K. This size seems to
result in occasional segfaults on engine startup,
likely due to being near a limit. Doubling the
stack size for these ULTs should avoid the problem.
Change-Id: Id339cc48985825ccce291ad288e1490920facf5c
Signed-off-by: Michael MacDonald mjmac@google.com