DAOS-17287 build: Remove separate rpm build for raft

[jolivier23]

Just include the submodule in the daos sources

Steps for the author:

• Commit message follows the guidelines.
• Appropriate Features or Test-tag pragmas were used.
• Appropriate Functional Test Stages were run.
• At least two positive code reviews including at least one code owner from each category referenced in the PR.
• Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

• Gatekeeper requested (daos-gatekeeper added as a reviewer).

[github-actions]

Ticket title is 'Remove separate daos-raft rpm build'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-17287

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-16094/1/execution/node/342/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-16094/1/execution/node/311/log

[daosbuild1]

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-16094/1/execution/node/261/log

[daosbuild1]

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-16094/1/execution/node/318/log

[liw]

Just for your reference, here's my old script that I tested carefully in the past. It used a different approach---more git archive than tar. Might be useful if you would like to verify the contents of the output tarball by comparing to one produced by a different approach.

#!/bin/bash
#
# Usage: archive.sh <dir> <name> <version> <extension>
#
# Create an archive of the HEAD commit of a local Git repository, including
# submodules.
#
#   - Must run at the root of the Git repository.
#   - Must have all submodules initialized and updated.
#   - Whitespaces are prohibited in any of the parameters.
#   - Submodules within submodules are not supported.
#
# For example,
#
#   archive.sh /a/b/c daos 1.2.3 tar
#
# produces /a/b/c/daos-1.2.3.tar.
#

set -e

dir=$1
name=$2
version=$3
ext=$4

# Use a temporary directory for all intermediate files.
unset tmp
trap 'if [ -n "$tmp" ]; then rm -rf "$tmp"; fi' EXIT
tmp=$(mktemp -d)

file_extless=$name-$version
file=$file_extless.$ext
sm_file_prefix=$file_extless-submodule

# Create an archive, which doesn't include any submodule.
git archive --prefix $name-$version/ -o $tmp/$file HEAD

# Add all submodules to the archive.
git submodule --quiet foreach \
	"git archive --prefix $name-$version/\$sm_path/ -o $tmp/$sm_file_prefix-\$name.$ext \$sha1"
tar -Af $tmp/$file $tmp/$sm_file_prefix-*.$ext

# Publish the archive.
mv $tmp/$file $dir/$file

[jolivier23]

#!/bin/bash

Usage: archive.sh

Create an archive of the HEAD commit of a local Git repository, including

submodules.

- Must run at the root of the Git repository.

- Must have all submodules initialized and updated.

- Whitespaces are prohibited in any of the parameters.

- Submodules within submodules are not supported.

For example,

archive.sh /a/b/c daos 1.2.3 tar

produces /a/b/c/daos-1.2.3.tar.

set -e

dir=$1
name=$2
version=$3
ext=$4

Use a temporary directory for all intermediate files.

unset tmp
trap 'if [ -n "$tmp" ]; then rm -rf "$tmp"; fi' EXIT
tmp=$(mktemp -d)

file_extless=$name-$version
file=$file_extless.$ext
sm_file_prefix=$file_extless-submodule

Create an archive, which doesn't include any submodule.

git archive --prefix $name-$version/ -o $tmp/$file HEAD

Add all submodules to the archive.

git submodule --quiet foreach
"git archive --prefix $name-$version/$sm_path/ -o $tmp/$sm_file_prefix-$name.$ext $sha1"
tar -Af $tmp/$file $tmp/$sm_file_prefix-*.$ext

Publish the archive.

mv $tmp/$file $dir/$file

thanks, Li Wei. I have a subsequent PR that is trying to do the same for spdk and will require recursion

[liw]

I think sm_path is more correct than displaypath, though if we are at the root of daos they are the same. For example, if we are in src, then

    sm_path=src/rdb/raft
displaypath=rdb/raft

while we always want the prefix to be name-version/src/rdb/raft.

[jolivier23]

@liw sm_path didn't work for recursive submodules (follow-on spdk patch) and the comment at the top says it has to be run from root.

[liw]

I see. Then let's go with displaypath.

[daosbuild1]

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-16094/10/display/redirect

[daosbuild1]

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-16094/10/display/redirect

[daosbuild1]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-16094/10/display/redirect

[daosbuild1]

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-16094/11/display/redirect

[daosbuild1]

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-16094/11/display/redirect

[daosbuild1]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-16094/11/display/redirect