Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-17286 control: Allow trailing separator in numericlist #16104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DAOS-17286 control: Allow trailing separator in numericlist #16104

wants to merge 2 commits into from
+18 −0

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Mar 15, 2025 •
edited
Loading

Allow trailing separator in bracketed list of ranges when creating a
numeric list from a string using the hostlist library. e.g.
CreateNumericSet("[1-5,6,]").

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@tanabarr
DAOS-17286 control: Allow trailing separator in numericlist
98e52aa 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested review from a team as code owners March 15, 2025 09:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2025 •
edited
Loading

Ticket title is 'dmg: pool query failed: creating numeric set from ... invalid range ""'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-17286

@tanabarr tanabarr self-assigned this Mar 15, 2025
@tanabarr tanabarr added bug control-plane work on the management infrastructure of the DAOS Control Plane go Pull requests that update Go code labels Mar 15, 2025
@tanabarr
Merge remote-tracking branch 'origin/master' into tanabarr/control-nu…
c0fa82c 
…mericlist-trailing-separator

Features: control
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@tanabarr tanabarr

Labels
bug control-plane work on the management infrastructure of the DAOS Control Plane go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanabarr @kjacque