-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-17207 build: Update spdk to v24.09 #63
base: master
Are you sure you want to change the base?
Conversation
jolivier23
commented
Mar 12, 2025
- Snapshot v24.09 and its dependencies and build a single RPM
- Remove Debian packaging (server component)
f4cab74
to
d67d252
Compare
spdk-24.09
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we use a generic name - spdk
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main issue was I needed the source in the tar ball to be name-version and this was the simplest way. it does mean adding new submodule for each version upgrade or moving it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But does that mean I have to rename it every time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out how to make this work. Renamed to src
Can we split this into smaller parts as the Jira ticket and PR title say only about upgrading SPDK but in fact we do a lot of more:
|
6b4b2f1
to
177e3d4
Compare
this is just not practical for me to do. I need to upgrade SPDK. Removing Ubuntu and switching to submodule (for new version) is the most practical way for me to do that. Otherwise, I have to create dpdk packages for this upgrade. |
77d7f22
to
43f81f7
Compare
Makefile
Outdated
echo $(basename $@) | ||
rm -f $@ | ||
git submodule update --init --recursive | ||
git ls-files --recurse-submodules $(NAME)-$(VERSION) | tar caf $(NAME)-$(VERSION).tar.gz -T- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW: This would allow you to use the "spdk" name for the submodule while still getting the correctly-named top directory in the tarball:
git ls-files --recurse-submodules $(NAME)-$(VERSION) | tar caf $(NAME)-$(VERSION).tar.gz -T- | |
git ls-files --recurse-submodules $(NAME) | tar caf $(NAME)-$(VERSION).tar.gz --transform='s/^$(NAME)/$(NAME)-$(VERSION)/' -T- |
b00e241
to
96acdbe
Compare
Snapshot v24.09 and its dependencies and build a single RPM Remove Debian packaging (server component) Signed-off-by: Jeff Olivier <jeffolivier@google.com>
b0576fa
to
0eaf695
Compare
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
82e0d04
to
432f8f7
Compare
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
929d3b2
to
1949531
Compare
8866668
to
9f8e741
Compare
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
9f8e741
to
03f28db
Compare
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
This reverts commit d262bee.
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>