Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17207 build: Update spdk to v24.09 #63

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

jolivier23
Copy link
Contributor

  • Snapshot v24.09 and its dependencies and build a single RPM
  • Remove Debian packaging (server component)

@jolivier23 jolivier23 requested a review from a team as a code owner March 12, 2025 02:12
@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 6 times, most recently from f4cab74 to d67d252 Compare March 12, 2025 06:42
spdk-24.09 Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use a generic name - spdk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main issue was I needed the source in the tar ball to be name-version and this was the simplest way. it does mean adding new submodule for each version upgrade or moving it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But does that mean I have to rename it every time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out how to make this work. Renamed to src

@grom72
Copy link
Contributor

grom72 commented Mar 12, 2025

Can we split this into smaller parts as the Jira ticket and PR title say only about upgrading SPDK but in fact we do a lot of more:

  • we permanently remove Ubuntu from validation in Jenkins
  • we introduce new way the SPDK is integrated with DAOS -> submodule

@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 2 times, most recently from 6b4b2f1 to 177e3d4 Compare March 12, 2025 17:22
@jolivier23
Copy link
Contributor Author

Can we split this into smaller parts as the Jira ticket and PR title say only about upgrading SPDK but in fact we do a lot of more:

  • we permanently remove Ubuntu from validation in Jenkins
  • we introduce new way the SPDK is integrated with DAOS -> submodule

this is just not practical for me to do. I need to upgrade SPDK. Removing Ubuntu and switching to submodule (for new version) is the most practical way for me to do that. Otherwise, I have to create dpdk packages for this upgrade.

@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 3 times, most recently from 77d7f22 to 43f81f7 Compare March 12, 2025 19:20
Makefile Outdated
echo $(basename $@)
rm -f $@
git submodule update --init --recursive
git ls-files --recurse-submodules $(NAME)-$(VERSION) | tar caf $(NAME)-$(VERSION).tar.gz -T-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: This would allow you to use the "spdk" name for the submodule while still getting the correctly-named top directory in the tarball:

Suggested change
git ls-files --recurse-submodules $(NAME)-$(VERSION) | tar caf $(NAME)-$(VERSION).tar.gz -T-
git ls-files --recurse-submodules $(NAME) | tar caf $(NAME)-$(VERSION).tar.gz --transform='s/^$(NAME)/$(NAME)-$(VERSION)/' -T-

@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 12 times, most recently from b00e241 to 96acdbe Compare March 13, 2025 02:52
Snapshot v24.09 and its dependencies and build a single RPM
Remove Debian packaging (server component)

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 9 times, most recently from b0576fa to 0eaf695 Compare March 13, 2025 07:17
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 3 times, most recently from 82e0d04 to 432f8f7 Compare March 13, 2025 16:07
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 2 times, most recently from 929d3b2 to 1949531 Compare March 13, 2025 21:35
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch 2 times, most recently from 8866668 to 9f8e741 Compare March 14, 2025 02:58
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the jvolivie/upgrade_2.4 branch from 9f8e741 to 03f28db Compare March 14, 2025 03:24
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
This reverts commit d262bee.
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants