Adding remote endpoint request from inside activity with retry #1388

salaboy · 2025-05-27T11:34:23Z

Description

Adding Spring Boot workflow example containing a remote request to a REST endpoint with retry policies

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1386

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

spring-boot-examples/workflows/pom.xml

...ows/src/main/java/io/dapr/springboot/examples/wfp/remoteendpoint/RemoteEndpointWorkflow.java

...amples/workflows/src/test/java/io/dapr/springboot/examples/wfp/DaprTestContainersConfig.java

spring-boot-examples/workflows/src/test/resources/third-parties/remote-http-service.yaml

siri-varma

LGTM. Thanks a lot for the great examples

artur-ciocanu · 2025-05-29T05:42:49Z

@salaboy love the examples, could you please take a look at the failing unit tests. Thank you.

Signed-off-by: salaboy <Salaboy@gmail.com>

* chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Clean up not used files Signed-off-by: Javier Aliaga <javier@diagrid.io> * docs: Task execution keys Signed-off-by: Javier Aliaga <javier@diagrid.io> * test: Modify unit tests Signed-off-by: Javier Aliaga <javier@diagrid.io> * Remove new lines Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>

This reverts commit 949584f. Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com>

Signed-off-by: Cassandra Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com>

Signed-off-by: salaboy <Salaboy@gmail.com>

* Update CONTRIBUTING.md Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Fix spring Signed-off-by: siri-varma <siri.varma@outlook.com> * Add context Signed-off-by: siri-varma <siri.varma@outlook.com> * Phase 1 Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix spring Signed-off-by: siri-varma <siri.varma@outlook.com> * Add context Signed-off-by: siri-varma <siri.varma@outlook.com> * Phase 1 Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * move version Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix pom Signed-off-by: sirivarma <siri.varma@outlook.com> * change version Signed-off-by: sirivarma <siri.varma@outlook.com> * remove unused Signed-off-by: siri-varma <siri.varma@outlook.com> * Address comments Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix test Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix test Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: sirivarma <siri.varma@outlook.com> --------- Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Signed-off-by: sirivarma <siri.varma@outlook.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>

Signed-off-by: salaboy <Salaboy@gmail.com>

artur-ciocanu

@salaboy love the example, I have just one tiny comment regarding RestTemplate, as far as I know RestClient is the recommended API since RestTemplate has been deprecated.

...s/workflows/src/main/java/io/dapr/springboot/examples/wfp/WorkflowPatternsConfiguration.java

...src/main/java/io/dapr/springboot/examples/wfp/remoteendpoint/CallRemoteEndpointActivity.java

artur-ciocanu · 2025-05-30T17:40:44Z

@salaboy could you please check my comment regarding RestTemplate, thank you!

salaboy · 2025-05-30T20:11:46Z

@artur-ciocanu I want to cover RestTemplate for now.. we can check with RestClient later.. RestClient is not as widely adopted as RestTemplate

salaboy · 2025-05-30T20:13:30Z

@salaboy love the examples, could you please take a look at the failing unit tests. Thank you.

All green now

codecov · 2025-05-31T01:28:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (d759c53) to head (d6c6e42).
Report is 162 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1388      +/-   ##
============================================
+ Coverage     76.91%   78.34%   +1.42%     
- Complexity     1592     1847     +255     
============================================
  Files           145      226      +81     
  Lines          4843     5707     +864     
  Branches        562      601      +39     
============================================
+ Hits           3725     4471     +746     
- Misses          821      916      +95     
- Partials        297      320      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

salaboy requested review from a team as code owners May 27, 2025 11:34

salaboy marked this pull request as draft May 27, 2025 11:34

salaboy force-pushed the 1386-http-endpoint-from-workflow branch from bc98433 to 9a4df89 Compare May 27, 2025 11:37