-
Notifications
You must be signed in to change notification settings - Fork 218
Custom reporter #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom reporter #741
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
.gitignore
Outdated
@@ -13,3 +13,5 @@ packages | |||
# Include when developing application packages. | |||
pubspec.lock | |||
.packages | |||
|
|||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this file change. .idea
files should be ignored in your global .gitignore file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevmoo done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @nex3 comment on the change overall
lib/test.dart
Outdated
@@ -41,6 +42,12 @@ export 'src/frontend/utils.dart'; | |||
/// This is used if a test file is run directly, rather than through the runner. | |||
Declarer _globalDeclarer; | |||
|
|||
typedef Reporter UserDefinedReporterCreateCallback(Engine engine); | |||
UserDefinedReporterCreateCallback _userDefinedReporterCallback; | |||
void setUserDefinedReporter(UserDefinedReporterCreateCallback callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid methods named setSomething
. You can have a set
method at the top level, but since this isn't doing any extra work we can also make the variable public instead of private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natebosch done
This approach won't work, for a couple reasons:
|
Added ability to define user custom reporter