Skip to content

Filter out large distances in test_linspace #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

honno
Copy link
Member

@honno honno commented Sep 29, 2022

Resolves #125

@honno honno requested a review from asmeurer September 29, 2022 12:51
@asmeurer
Copy link
Member

I suppose this is different from numpy/numpy#18881.

This looks good. One could probably get more fine grained by allowing large start and stop as long as they are themselves close to one another (look at the ratio start/stop), but it's probably not a huge deal either way.

@honno
Copy link
Member Author

honno commented Sep 30, 2022

I suppose this is different from numpy/numpy#18881.

Ayup, this relates to numpy/numpy#21585

This looks good. One could probably get more fine grained by allowing large start and stop as long as they are themselves close to one another (look at the ratio start/stop), but it's probably not a huge deal either way.

I think this does still generate such cases. Only the distance between start and stop is checked (after-the-fact), rather than having limits on start and stop.

@honno
Copy link
Member Author

honno commented Oct 4, 2022

Seems uncontroversial and is nice for our CI, so merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not generate incredibly large distances for test_linspace
2 participants