Skip to content

ENH: add ARRAY_API_TESTS_XFAIL_MARK to turn xfails into skips #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented May 11, 2025

Locally, this speeds the torch test run by a factor of 4 or more.

@ev-br
Copy link
Member Author

ev-br commented May 11, 2025

Turning xfails into skips looks like a no-brainer, based on data-apis/array-api-compat#321

Am now checking the effect of lowering MAX_ARRAY_SIZE down to 1024 from 10_000. This is expected to help with elementwise array iterations. The effect of MAX_ARRAY_SIZE is less obvious, let's back it off for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant