-
Notifications
You must be signed in to change notification settings - Fork 107
Support Python 3.13 and update deps #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Remove upper caps on numpy and pyarrow versions Signed-off-by: David Black <dblack@atlassian.com>
Signed-off-by: David Black <dblack@atlassian.com>
Signed-off-by: David Black <dblack@atlassian.com>
Signed-off-by: David Black <dblack@atlassian.com>
Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com>
Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com>
26ff88a
to
c53928a
Compare
cc @rcypher-databricks @yunbodeng-db @andrefurlan-db @jackyhu-db @benc-db for review 🙏 . |
Thanks for raising this, @dhirschfeld. For passing the DCO test, we need to have DCO tests in GitHub Actions ensure code contributions are legally sound. We are implementing stricter DCO checks. Currently, DCO compliance is not enforced as a pre-merge requirement. Sample PR where DCO passes : https://github.com/databricks/databricks-sql-python/pull/461/commits. |
@samikshya-db - I had sign offs in my commit messages and my PR (#504) still was red for DCO. The check seems to be failing because of permissions issues no?
& the comment fails due to a different perms issue it seems.
|
As @dbaxa says, all commits have been signed off. The DCO check is broken because the necessary IP address is being blocked. |
DCO sign-off should be part of every commit for the DCO GH action to pass (the merge commit too). The message that you posted is actually a red-herring. I agree that this GH action should be more developer friendly :/ Created : #519 to address this. Thanks for the contribution! |
Thanks for the merge @samikshya-db! If anyone here has commit rights in |
* Remove upper caps on dependencies (databricks#452) * Remove upper caps on numpy and pyarrow versions Signed-off-by: David Black <dblack@atlassian.com> * Added CI CD upto python 3.13 Signed-off-by: David Black <dblack@atlassian.com> * Specify pandas 2.2.3 as the lower bound for python 3.13 Signed-off-by: David Black <dblack@atlassian.com> * Specify pyarrow 18.0.0 as the lower bound for python 3.13 Signed-off-by: David Black <dblack@atlassian.com> * Move `numpy` to dev dependencies Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com> * Updated lockfile Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com> --------- Signed-off-by: David Black <dblack@atlassian.com> Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com> Co-authored-by: David Black <dblack@atlassian.com> Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
All tests pass1 with no explicit
numpy
dependency.Resolves #509
Closes #504 - (changes have been merged here)
Footnotes
Except the broken DCO check ↩