Check JAVA_HOME before java.home to locate JDK home #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I mis-read your PR. It's fine |
|
And sorry I miss-spelled JRE with JDK. |
|
np, Thanks. |
Closed
cdc6d
added a commit
to cdc6d/geomesa
that referenced
this pull request
Dec 6, 2018
…ot POM. This version of the plugin requires at least Maven 3.3.9. Update README.md accordingly. Delete the incomplete building instructions in CONTRIBUTING.md and refer to README.md instead. Since version 3.3.1, the scala-maven-plugin's way of invoking Zinc changed so that Zinc may look in the wrong path for the "javac" command. Since version 3.3.2, this problem can be defeated by setting the JAVA_HOME environment variable: davidB/scala-maven-plugin#227 Add a note about this to the README because it caused me trouble.
cdc6d
added a commit
to cdc6d/geomesa
that referenced
this pull request
Dec 6, 2018
…ot POM. This version of the plugin requires at least Maven 3.3.9. Update README.md accordingly. Delete the incomplete building instructions in CONTRIBUTING.md and refer to README.md instead. Since version 3.3.1, the scala-maven-plugin's way of invoking Zinc changed so that Zinc may look in the wrong path for the "javac" command. Since version 3.3.2, this problem can be defeated by setting the JAVA_HOME environment variable: davidB/scala-maven-plugin#227 Add a note about this to the README because it caused me trouble. No significant diffs in the console output of a full build. Signed-off-by: Carsten Clark <github-cdc@ccri.com>
jnh5y
pushed a commit
to locationtech/geomesa
that referenced
this pull request
Dec 12, 2018
* GEOMESA-2478 Update git-commit-id-plugin to latest version. Upgrade git-commit-id-plugin from 2.2.1 to the latest version, 2.2.5, in the root POM. The previous versions of the plugin were hanging for me when trying to build. Upgrading fixed that issue for me. This might have to do with the following bug: git-commit-id/git-commit-id-maven-plugin#336 Note: the version in the root POM was last updated from 2.1.13 to 2.2.1 in May 2017. In 3 other POMs, remove git-commit-id-plugin <version> which was set to 2.1.13 (perhaps originally copied from the root POM): * geomesa-accumulo-tools/pom.xml, geomesa-lambda-tools/pom.xml: version 2.1.13 was selected in the initial commits of these POMs in Sep 2016 and July 2017. The latter may have been copy-pasted from the former. * geomesa-fs-tools/pom.xml: version 2.1.13 was selected in the git-commit-id-plugin configuration when it was added to this build in Sep 2017... perhaps copy-paste from one of the above two POMs. Signed-off-by: Carsten Clark <github-cdc@ccri.com> * GEOMESA-2478 Update all core Maven plugins to their latest versions. Update all maven-*-plugin entries in the root POM's pluginManagement to the latest version for each plugin. Latest version info obtained from https://maven.apache.org/plugins/ which turned out to match what was available in Maven Central at http://repo.maven.apache.org/maven2/org/apache/maven/plugins/ Add a comment to each maven-*-plugin configuration saying when the version was released, to make it easier to spot potentially out-of-date plugins. Upgrading the maven-compiler-plugin required turning off its new 'useIncrementalCompilation' option in order to keep it from recompiling Java files that the scala-maven-plugin already compiled. I see no significant differences in the output of "build/mvn install" before and after this change (other than the plugin version numbers). Signed-off-by: Carsten Clark <github-cdc@ccri.com> * GEOMESA-2478 Add pluginManagement entries for 3 missing core Maven plugins. Again no significant diffs in the console output of a full build. Signed-off-by: Carsten Clark <github-cdc@ccri.com> * GEOMESA-2478 Bump license-maven-plugin from 2.10 to 3.10 in root POM. 3.0 was released 2016-08-20 and is the latest as of 2018-11-30. Again no significant diffs in the console output of a full build. Signed-off-by: Carsten Clark <github-cdc@ccri.com> * GEOMESA-2478 Upgrade scala-maven-plugin from 3.2.1 to 3.4.4 in the root POM. This version of the plugin requires at least Maven 3.3.9. Update README.md accordingly. Delete the incomplete building instructions in CONTRIBUTING.md and refer to README.md instead. Since version 3.3.1, the scala-maven-plugin's way of invoking Zinc changed so that Zinc may look in the wrong path for the "javac" command. Since version 3.3.2, this problem can be defeated by setting the JAVA_HOME environment variable: davidB/scala-maven-plugin#227 Add a note about this to the README because it caused me trouble. No significant diffs in the console output of a full build. Signed-off-by: Carsten Clark <github-cdc@ccri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.getProperty("java.home")return the path to the JDK and cannot be override.JAVA_HOMEshould be checked before this to allow users to actually affect the path sent to the zinc server, other than using the toolchain plugin.This fixes issue #221.