Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions using Rust nightly on Windows/MSYS2 #162

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

lautis0503
Copy link
Contributor

Two potential problems should be solved later:

  1. When using rustup-init.sh to install Rust nightly, the host x86_64-pc-windows-gnu is speicified directly. Better to use variable from environment matrix mingw-w64-x86_64.
  2. After Rust nightly installed, neither export new PATH nor echo PATH >>$GITHUB_ENV worked for MSYS2. The cargo command is called from its default location. Better to set the path of rust/cargo expicitly to prevent from possible change of default installation location.

The Linux and macOS workflows are untouched.
BTW, why we need to build using nightly?

@dbalsom
Copy link
Owner

dbalsom commented Mar 1, 2025

Two potential problems should be solved later:

  1. When using rustup-init.sh to install Rust nightly, the host x86_64-pc-windows-gnu is speicified directly. Better to use variable from environment matrix mingw-w64-x86_64.
  2. After Rust nightly installed, neither export new PATH nor echo PATH >>$GITHUB_ENV worked for MSYS2. The cargo command is called from its default location. Better to set the path of rust/cargo expicitly to prevent from possible change of default installation location.

Bless you if this works. I beat my head against the wall trying it

The Linux and macOS workflows are untouched. BTW, why we need to build using nightly?

The new WASM build needs nightly for building std with atomics to enable threading with web workers.
The native build probably doesn't need it. I haven't figured out if I can set the required toolchain by target...

@dbalsom dbalsom merged commit b5abb45 into dbalsom:version_0_4_0 Mar 1, 2025
1 of 4 checks passed
@dbalsom
Copy link
Owner

dbalsom commented Mar 1, 2025

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants