SN wrangler_utils add set_property #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magma_smaht/wrangler_utils.py
Outdated
| def set_property( | ||
| uuid: str, | ||
| prop_key: str, | ||
| prop_value: Union[str,int], |
There was a problem hiding this comment.
prop_value could also be a list. Any is probably fine here. Validation will be done portal side anyway and it will fail if we try to patch some unexpected.
magma_smaht/wrangler_utils.py
Outdated
| ff_utils.patch_metadata(patch_body, obj_id=uuid, key=smaht_key) | ||
| print(f"Set item {uuid} property {prop_key} to {prop_value}.") | ||
| except Exception as e: | ||
| raise Exception(f"Item could not be PATCHed: {e}") |
There was a problem hiding this comment.
We might need str(e) here. This might be wrong in other places. Please correct those as well.
|
Actually your function args should be fine. |
| @click.help_option("--help", "-h") | ||
| @click.option( | ||
| "-m", | ||
| "--mwfr-identifier", |
There was a problem hiding this comment.
This should -i and --identifier
| type=str, | ||
| help="Name of environment in smaht-keys file", | ||
| ) | ||
| def set_property(mwfr_identifier,property_key,property_value,auth_env): |
There was a problem hiding this comment.
mwfr_identifier => identifier
alexander-veit
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function
set_propertytowrangler_utils.pythat can patch property values by uuid.