Support for Python 3.12 #35
Conversation
.github/workflows/main.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| runs-on: ubuntu-22.04 | |||
| strategy: | |||
| matrix: | |||
| python_version: ['3.8', '3.9', '3.10', '3.11'] | |||
| python_version: ['3.9', '3.10', '3.11', '3.12'] | |||
There was a problem hiding this comment.
Is there a reason, you removed 3.8 from the tests?
There was a problem hiding this comment.
Yeah I should put that back, with some repos careful to include minimal set due to time, but this is pretty quick.
pyproject.toml
Outdated
| python = ">=3.8.1,<3.13" | ||
| dcicutils = "^8.13.3" | ||
| docutils = ">=0.10,<0.17," | ||
| tibanna-ff = "3.4.2.1b2" |
There was a problem hiding this comment.
Adjust version upon release of tibanna-ff
pyproject.toml
Outdated
| tibanna-ff = ">=3.2.0" | ||
| python = ">=3.8.1,<3.13" | ||
| dcicutils = "^8.13.3" | ||
| docutils = ">=0.10,<0.17," |
There was a problem hiding this comment.
Why do we need this now?
There was a problem hiding this comment.
Removed; was artifact of some troubleshooting of some problem; not needed there though.
| python = ">=3.8,<3.12" | ||
| dcicutils = "^8.0.0" | ||
| tibanna-ff = ">=3.2.0" | ||
| python = ">=3.8.1,<3.13" |
There was a problem hiding this comment.
I would not exclude 3.8.0 here if there is no good reason. Technically that would be a breaking change.
There was a problem hiding this comment.
Okay, will have to make dcicutils be >=3.8 too which requires downgrading flake8, etc; I can see how that goes.
There was a problem hiding this comment.
Oh, I see. You can leave 3.8.1 then. It's just us using it. Should be fine.
No description provided.