-
Notifications
You must be signed in to change notification settings - Fork 8
Fix module import statements and nested type fields in protoc-gen-d. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for the contribution! |
OK. I added a proto in |
a7f48e9
to
a89ecda
Compare
FYI I confirmed that travis-ci.com worked on my side https://travis-ci.com/github/ShigekiKarita/protobuf-d/jobs/514841261#L1096 |
b7b8bee
to
7278b55
Compare
Thanks for the review comments. I believe everything is done. |
55dc8a1
to
c7c29b5
Compare
c7c29b5
to
a1788d7
Compare
Hi @dcarp, I just noticed that you replaced Travis with GitHub action recently. And I merged the master branch. Can you approve running the workflows? |
Protoc on this file: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/protobuf/debug_event.proto
generates broken code like this
There are two kinds of errors.
1 import module name is not equal to generated files
For example, this line is invalid:
It should be
import tensorflow.graph_debug_info
because it is generated as{package}/{proto basename}.d
.2 nested type field declaration omits its outer class
This line contains an invalid type name:
The
FileLineCol
must beGraphDebugInfo.FileLineCol
because the message is nestedhttps://github.com/tensorflow/tensorflow/blob/161381e3379c9c5bb47acd994838850efde7a385/tensorflow/core/protobuf/graph_debug_info.proto#L11-L13