You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I could provide you with a corresponding pull request and wanted to check if this is actually wanted before I waste my time...
I could refactor build.gradle to build.gradle.kts that supports the statically typed Kotlin DSL and runs without deprecation warnings with the latest version of Gradle.
Also the idiomatic way shipping Gradle projects is actually committing the Gradle binary into the repository. This might not be needed for Maven which remains API stable for years. However what runs with gradlew build on your computer will much more likely not run on my or even on your own just 6 months later. Therefore it is highly advisable to ship the Gradle binary to avoid frustration for people "who just want to evaluate..." :)
The text was updated successfully, but these errors were encountered:
@RobAltena is about to start working on that for Android, but a Gradle build for the rest of the examples would obviously be also welcome.
Note that because of restrictions from Eclipse, we cannot put binary blobs in this repository. In any case, please open a pull request if/when you have something to review! Thanks
@RobAltena Yes, it is. It's basically all about shipping the blob of a very fast moving build tool. Alternatively a specific Gradle version should be mentioned that successfully build the project. A blob-less approach would be to commit just ./gradle/wrapper/gradle-wrapper.properties.
@saudet thanks, but all of their examples seem to be based on Maven.
So I will try to provide you with a corresponding PR for this issue by the end of this week. If I should not provide any feedback or a PR by then, consider this issue abandoned (by me).
loxal
added a commit
to loxal/deeplearning4j-examples
that referenced
this issue
Apr 20, 2020
…L with the latest Gradle v6.3
* provide specific & tested Gradle version to guarantee a working example
* convert dynamically-typed Gradle script to statically-typed Kotlin DSL
* update dependencies
* cleanup imports
Signed-off-by: Alex <alexander.orlov@loxal.net>
I could provide you with a corresponding pull request and wanted to check if this is actually wanted before I waste my time...
I could refactor
build.gradle
tobuild.gradle.kts
that supports the statically typed Kotlin DSL and runs without deprecation warnings with the latest version of Gradle.Also the idiomatic way shipping Gradle projects is actually committing the Gradle binary into the repository. This might not be needed for Maven which remains API stable for years. However what runs with
gradlew build
on your computer will much more likely not run on my or even on your own just 6 months later. Therefore it is highly advisable to ship the Gradle binary to avoid frustration for people "who just want to evaluate..." :)The text was updated successfully, but these errors were encountered: