Feat/add masked flag to tf provider #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop HUBS-2073 | Release Version 3.2.0 | Develop -> Main
…develop ESCL-4868 | Release Version 3.2.1 | Develop -> Main
…develop ESCL-4870 | Release Version 3.2.2 | Develop -> Main
AzySir
approved these changes
Jun 14, 2024
|
Changing the base to develop branch. We are in the process of reviewing it, we will review it and merge it and will let you know. Thanks |
|
Any updates on this matter? Thanks |
|
Hi Yes, @rafaribe the change looks good to me. I will approve the change. We will proceeding with our standard tests and regression procedure. |
Uddipaan-Hazarika
approved these changes
Jun 20, 2024
gmanhas23
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
I want to be able to provision Masked VDB's via the terraform provider, the API has a
maskedflag that allows a user to mark the VDB as masked, but the terraform provider didn't had that option.Problem:
Terraform provider won't allow masked VDB's to be created while the API would.
Solution:
Add masked as a flag to the VDB resource int he terraform provider to allow the TF provider to pass this flag along to the DCT API.
Testing
We hot-replaced the binary for the provider with a compiled version that I created and tested it with DCT version 16.0.0.0
Implementation:
Simple implementation, I just added the masking flag to VDB's for
snapshot,timestamporbookmarkprovision_typeauxiliary methods and therefore the provisioning for masked VDB's works across all three types.