-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission sets in deno.json #27483
base: main
Are you sure you want to change the base?
permission sets in deno.json #27483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, one thing I'd like to see early in this PR is change for the FS operations that try to modify the deno.json(c)
file to require -A
permission instead of regular -R/-W
.
I'm not sure we should have this functionality. I think maybe as part of the risk of using the |
14b2bd3
to
4d6a2c0
Compare
deno_core::anyhow::anyhow!( | ||
"failed to find permission set named \"{name}\"" | ||
) | ||
})?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't error if someone does -P
and the default set doesn't exist. That way someone can run something like deno test -P
unconditionally.
POC
(uses
default
permission set, you can specify-P=other
or--permission-set=other
to use another)