Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve <Head /> ergonomics #165

Merged
merged 4 commits into from
May 9, 2023
Merged

refactor: improve <Head /> ergonomics #165

merged 4 commits into from
May 9, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 8, 2023 •
edited
Loading

This change:

  1. Moves <Meta /> into @/components/Head.tsx, as <Header /> is the only component that uses <Meta />.
  2. Adds defaults <Meta /> properties, cleaning the component up a bit.
  3. Defines the href property value where <Head /> is used around the codebase.
  4. Makes the new non-default page title be ${props.title} ▲ ${SITE_NAME}.

@iuioiua iuioiua requested a review from kt3k May 8, 2023 11:24
@iuioiua iuioiua merged commit 1f18cb4 into main May 9, 2023
@iuioiua iuioiua deleted the refactor-head-with-meta branch May 9, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k Awaiting requested review from kt3k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @VladimirCreator