Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append cookies in the response from supabase #203

Merged
merged 1 commit into from
May 16, 2023
Merged

Append cookies in the response from supabase #203

merged 1 commit into from
May 16, 2023

Conversation

zaynetro
Copy link
Contributor

Supabase client sets two cookies during logout:

set-cookie supabase-auth-token=; SameSite=Lax; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT
set-cookie supabase-auth-token-code-verifier=; SameSite=Lax; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT

Previously, with set method the first cookie was not returned to the browser.

Fixes #153

@zaynetro zaynetro mentioned this pull request May 16, 2023
Closed
iuioiua
iuioiua approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Simple solution. Thank you, @zaynetro.

@iuioiua iuioiua merged commit a62213e into denoland:main May 16, 2023
@zaynetro zaynetro deleted the patch-1 branch May 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: logout is not working
2 participants
@zaynetro @iuioiua