Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Docker files #253

Merged
merged 5 commits into from
Jun 19, 2023
Merged

docs: add Docker files #253

merged 5 commits into from
Jun 19, 2023

Conversation

lambtron
Copy link
Collaborator

@lambtron lambtron commented Jun 7, 2023

Addresses #227

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the appropriate snippets these new files replace in the README?

@lambtron lambtron mentioned this pull request Jun 9, 2023
5 tasks
@iuioiua
Copy link
Contributor

iuioiua commented Jun 11, 2023

I made the changes based on my original suggestions. PTAL.

@iuioiua iuioiua changed the title add docker files to repo docs: add Docker files Jun 11, 2023
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @lambtron and @cdoremus, please review after the merge.

@iuioiua iuioiua merged commit c470c4d into main Jun 19, 2023
@iuioiua iuioiua deleted the trim-readme branch June 19, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants