Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent homepage from crashing #583

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented Sep 12, 2023

currently https://hunt.deno.land/ crashes with the following error in the console:

Bildschirm­foto 2023-09-13 um 00 17 44

this seems to happen whenever any of the items still uses the old data model w/ uuid and createdAt, rather than ulid.
this pr adds a quick and naive try/catch block to prevent the page items list from crashing.

however the underlying issue should be handled via a db migration on prod's database.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this out! Thank you

@iuioiua iuioiua merged commit 5172937 into denoland:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants