check if a password column exists and only then check contents #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
micheelengronne
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Sounds good. I have a more general question though. Is it still relevant to keep compatibility for 5 years old deprecated behaviour ? mysql 5.7.6 appeared in 2015, if a system is still running with something older, I think security checks would be useless and the first thing to do would be to update.
|
You're right that we should not support deprecated behavior. However MariaDB still uses the password-column so we still need to check it. Do you have a better idea how to achieve this? Here are the versions our supported OS'es use:
|
|
If MariaDB still needs it, the checks is usefull then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Gumprich github@gumpri.ch
Fixes #52