New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: access manager #6377

Merged

Shivam-nagar23 merged 95 commits into develop from feat-access-manager

Mar 10, 2025

Member

Shivam-nagar23 commented Feb 10, 2025 •

edited

Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1613

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


          specs

322dce7

Shivam-nagar23 requested review from vikramdevtron, nishant-d, prakarsh-dt and vivek-devtron as code owners

February 10, 2025 08:51

github-actions bot added the PR:Issue-verification-failed label

Shivam-nagar23 added 8 commits

February 10, 2025 14:28


          specs

138105a


          specs for generic api

c2840c2


          specs for generic api update

18fbf7e


          access manager generic apis

78c62db


          enforcements

d4e37fb


          version changed to alpha1

e8ef17b


          specs udpate

9babb91


          version

e80919b

nishant-d requested changes

View reviewed changes

api/cluster/EnvironmentRestHandler.go Outdated Show resolved Hide resolved

pkg/userResource/UserResourceExtendedService.go Outdated Show resolved Hide resolved

pkg/userResource/UserResourceExtendedService.go Outdated Show resolved Hide resolved

pkg/userResource/UserResourceRbacExtendedService.go Outdated Show resolved Hide resolved

pkg/userResource/UserResourceService.go Outdated Show resolved Hide resolved

pkg/userResource/logicRouteService.go Show resolved Hide resolved

Shivam-nagar23 added 15 commits

February 14, 2025 11:12


          sql scripts

2a06a3d


          role group service refactoring

2e8d88a


          role group service

a4f3e5d


          sql script chnages

355d506


          sql scripts chnages

2e45765


          refactoring iss

04a7385


          reafctoring and rbac changes

91bd157


          get rbac changes

cf99d8b


          policy moved to bean

8e8ec51


          removed unnecessary code

3dc10bb


          v2 routes in oss

bc1954c


          Merge branch 'feat-access-manager-1' into feat-access-manager-2

e97436f


          Merge branch 'feat-access-manager-2' into feat-access-manager-3

80392b1


          sql script chnaged

24c88af


          sql script changes

9407b53

Shivam-nagar23 and others added 8 commits

February 24, 2025 11:49


          user service


          review comments

84cf514


          Merge pull request #6414 from devtron-labs/feat-access-manager-oss-en…

6fb8fbf

…t-sync

feat:  oss ent refactoring


          Merge branch 'develop' into feat-access-manager

53f94cd


          sql script chnage

05a1ae5


          get flow

3422fad


          nul data in case of unauthroised

f38e973


          user admin

30b758a

github-actions bot added PR:Ready-to-Review and removed PR:Issue-verification-failed labels

github-actions bot commented Feb 28, 2025

The migration files have successfully passed the criteria!!


          Merge branch 'develop' into feat-access-manager

github-actions bot commented Feb 28, 2025

The migration files have successfully passed the criteria!!

Shivam-nagar23 added 2 commits

March 3, 2025 11:08


          get group policy

c873624


          Merge branch 'develop' into feat-access-manager

cf9b997

github-actions bot commented Mar 3, 2025

The migration files have successfully passed the criteria!!

1 similar comment

github-actions bot commented Mar 3, 2025

The migration files have successfully passed the criteria!!


          naming

0a48005

github-actions bot commented Mar 3, 2025

The migration files have successfully passed the criteria!!


          sql scripts

ed1488e

github-actions bot commented Mar 7, 2025

The migration files have successfully passed the criteria!!

1 similar comment

github-actions bot commented Mar 8, 2025

The migration files have successfully passed the criteria!!

vikramdevtron approved these changes

View reviewed changes

vikramdevtron approved these changes

View reviewed changes

nishant-d approved these changes

View reviewed changes


          Merge branch 'develop' into feat-access-manager

915d1e0

github-actions bot commented Mar 10, 2025

The migration files have successfully passed the criteria!!

Shivam-nagar23 merged commit 050161b into develop

4 checks passed

Shivam-nagar23 deleted the feat-access-manager branch

March 10, 2025 05:32

sonarqubecloud bot commented Mar 10, 2025

Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nishant-d nishant-d approved these changes

vikramdevtron vikramdevtron approved these changes

prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Labels

PR:Ready-to-Review