Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump nodejs to v20 #4964

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: bump nodejs to v20 #4964

wants to merge 3 commits into from

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Mar 21, 2025 •
edited
Loading

I tried v22 first, but it causes problems with nix-build -A js, so let's be cautious...

@ggreif ggreif changed the title chore: bump nodejs to v22 chore: bump nodejs to v20 Mar 22, 2025
@ggreif ggreif requested review from crusso and rvanasa March 22, 2025 01:31
@ggreif ggreif marked this pull request as ready for review March 22, 2025 01:32
@ggreif ggreif requested a review from a team as a code owner March 22, 2025 01:32
@ggreif ggreif self-assigned this Mar 22, 2025
@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Mar 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

Comparing from e8d616d to d946c92:
The produced WebAssembly code seems to be completely unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso Awaiting requested review from crusso

@rvanasa rvanasa Awaiting requested review from rvanasa

At least 1 approving review is required to merge this pull request.

Assignees

@ggreif ggreif

Labels
automerge-squash When ready, merge (using squash)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ggreif